Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed build for Python 3.12 and added to CI #126

Closed
wants to merge 1 commit into from
Closed

Fixed build for Python 3.12 and added to CI #126

wants to merge 1 commit into from

Conversation

DominicOram
Copy link

This fixes the build for Python 3.12. Note that I haven't done extensive testing of p4p in 3.12, just got the build working.

Main change was that get_numpy_include_dirs is now replaced with numpy.get_include. These have been replaced with a preference for the newer version.

Also found that SETUPTOOLS_USE_DISTUTILS=stdlib was breaking 3.12 builds. Removing it seemed to cause no build issues but if this is wrong please let me know.

This was referenced Oct 29, 2023
Open
Closed
@evalott100 evalott100 mentioned this pull request Oct 30, 2023
Closed
@evalott100 evalott100 mentioned this pull request Nov 8, 2023
Merged
@DominicOram
Copy link
Author

@mdavidsaver - anything I can do to help get this merged?

@mdavidsaver
Copy link
Member

If you split the workflow change as a separate commit. I think the changes to setup.py and makehelper.py can go in now.

Merging the GHA workflow part of the change requires first adding py3.12 builds for the dependent modules epicscorelibs and pvxslibs. I you are willing to wait, I hope to have time to do this soon-ish. Alternately, I would not say "no" if you are willing to help :)

@DominicOram
Copy link
Author

Thanks @mdavidsaver. I had a quick look at them both but I think my knowledge of python build systems is insufficient to fix them quickly. I'm happy to wait for a full solution, thanks!

@dperl-dls dperl-dls mentioned this pull request Apr 3, 2024
Closed
@DominicOram
Copy link
Author

I believe the changes to setup.py and makehelper.py have been done in a03400e, apologies I didn't get round to tidying this PR. The GHA actions is still waiting on the other modules and I stand by not having the time to look at them myself right now so happy to close this PR.

@DominicOram DominicOram closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DominicOram @mdavidsaver